Translate library/string#738
Merged
mattwang44 merged 3 commits intopython:3.12from Feb 8, 2024
Merged
Conversation
Collaborator
我覺得 ok 不過 library/string.po 我們上次 meetup 也在翻譯,目前看起來好像部分有跟其他 PR 有重複,我會優先 review 先前的 PR |
Contributor
Author
|
好的沒有問題,抱歉沒注意到。那我再去找其他的來翻譯🙂 |
Collaborator
|
@tso1158687 |
b680bec to
9b36ded
Compare
mattwang44
reviewed
Jan 15, 2024
Collaborator
mattwang44
left a comment
There was a problem hiding this comment.
good enough to be merged, only two minor issues
Collaborator
@tso1158687 這部分已經處理完 (#731),再麻煩你有空的時候幫忙修正 & resolve conflicts |
Collaborator
|
@tso1158687 如果你目前沒辦法處理的話我就來接手修正囉? |
Contributor
Author
|
不好意思我沒有注意到訊息,我馬上來修正一下 |
9b36ded to
976d830
Compare
mattwang44
previously approved these changes
Feb 8, 2024
Collaborator
mattwang44
left a comment
There was a problem hiding this comment.
只剩一個小問題,我就直接 commit 了,感謝 🙏🏽
mattwang44
approved these changes
Feb 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Translate
ASCII characters 這個詞我有點糾結要翻譯成什麼,最後選擇ASCII 字元,可以看看這樣的說法是否恰當,或是說有更好的建議!